Skip to content

Commit 267af86

Browse files
authored
fix: promises should resolve correctly (#127)
Fixes use cases where code like this might never resolve: ```js scrollIntoView([HTMLElement], { scrollMode: 'if-needed', block: 'nearest' }).then(() => { console.log('done') }) ``` Fixes scroll-into-view/scroll-into-view-if-needed#344
1 parent c8aa5a2 commit 267af86

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ function step(context: Context) {
5050
// scroll more if we have not reached our destination
5151
if (currentX !== context.x || currentY !== context.y) {
5252
requestAnimationFrame(() => step(context))
53+
} else {
54+
// If nothing left to scroll lets fire the callback
55+
context.cb()
5356
}
5457
}
5558

0 commit comments

Comments
 (0)