-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: typos in scroll-tech / zkevm-circuits #1219
Comments
no |
I don't quite understand what "No" means. |
Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up? |
It would be good. Unfortunately, the issue has been open for a long time, but there is no reaction from the team. Maybe @DreamWuGit will respond |
thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO. |
Disagree with your last one but made a PR for the sake of closing this out. |
can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc |
that's welcome! |
zkevm-circuits/zktrie/src/state.rs
Line 72 in a08da07
"is not need" should be "is not needed"
zkevm-circuits/bus-mapping/src/rpc.rs
Line 118 in a08da07
"it's" should be "its"
zkevm-circuits/gadgets/src/is_zero.rs
Line 4 in a08da07
"witnesses" should be "witnesses:"
zkevm-circuits/gadgets/src/is_zero.rs
Line 17 in a08da07
"implementation" should be "implementing"
The text was updated successfully, but these errors were encountered: