Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typos in scroll-tech / zkevm-circuits #1219

Open
alexanderblv opened this issue Apr 18, 2024 · 8 comments
Open

chore: typos in scroll-tech / zkevm-circuits #1219

alexanderblv opened this issue Apr 18, 2024 · 8 comments

Comments

@alexanderblv
Copy link

/// new snapshot since we consider it is not need to send more nodes data

"is not need" should be "is not needed"

/// returning all the block information including it's transaction's

"it's" should be "its"

//! - witnesses `inv0(value)`, where `inv0(x)` is 0 when `x` = 0, and

"witnesses" should be "witnesses:"

/// implement `IsZero`.

"implementation" should be "implementing"

@chenyuan1189
Copy link

no

@alexanderblv
Copy link
Author

no

I don't quite understand what "No" means.

@Kajko25
Copy link

Kajko25 commented May 5, 2024

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

@alexanderblv
Copy link
Author

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

It would be good. Unfortunately, the issue has been open for a long time, but there is no reaction from the team. Maybe @DreamWuGit will respond

@lispc
Copy link

lispc commented Jun 1, 2024

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

@drstevenbrule
Copy link

Disagree with your last one but made a PR for the sake of closing this out.

@xyq-c-cpp
Copy link

xyq-c-cpp commented Jun 13, 2024

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

@lispc
Copy link

lispc commented Jun 13, 2024

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

that's welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants