Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when precompile fails, don't need copy event lookup ? #898

Open
DreamWuGit opened this issue Sep 5, 2023 · 1 comment
Open

when precompile fails, don't need copy event lookup ? #898

DreamWuGit opened this issue Sep 5, 2023 · 1 comment

Comments

@DreamWuGit
Copy link

DreamWuGit commented Sep 5, 2023

Describe the feature you would like

currently there is three copy events in successful and failed precompiles run:

  1. copy caller memory --> calldata
  2. copy calldata --> callee memory
  3. callee memory --> calldata memory.

for precompile error cases, like OOG case, at least the last two steps don't not happens. seems reasonable to not do lookup copy table ?

Additional context

No response

@roynalnaruto
Copy link

We will need to refactor bus-mapping and callop in that case. Would you like to take that up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants