Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bus-mapping): most consistent way of using rw #919

Open
lispc opened this issue Sep 7, 2023 · 0 comments
Open

refactor(bus-mapping): most consistent way of using rw #919

lispc opened this issue Sep 7, 2023 · 0 comments
Labels
refactor

Comments

@lispc
Copy link

lispc commented Sep 7, 2023 •
edited
Loading

Describe the feature you would like

  1. use CircuitInputStateRef.stack_push/stack_pop if viable. Except DUP/SWAP, most usage of stack_read/stack_write can be replaced by stack_pop/stack_push. Need to keep track of stack ptr inside bus-mapping.
  2. add & use helper function for StorageOp/TxAccessListAccountStorageOp/TxRefundOp too.

Additional context

No response
@lispc lispc changed the title refactor(bus-mapping): most consistent way of using ew refactor(bus-mapping): most consistent way of using rw Sep 9, 2023
@lispc lispc added the refactor label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lispc