From d6953fd3cecf79e6e5bb2494c89acec4cece4d69 Mon Sep 17 00:00:00 2001 From: kunxian xia Date: Wed, 29 May 2024 19:35:22 +0800 Subject: [PATCH 1/2] fix next_tx --- zkevm-circuits/src/tx_circuit.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zkevm-circuits/src/tx_circuit.rs b/zkevm-circuits/src/tx_circuit.rs index 73c8eac1a1..5e383a2208 100644 --- a/zkevm-circuits/src/tx_circuit.rs +++ b/zkevm-circuits/src/tx_circuit.rs @@ -4323,7 +4323,7 @@ impl TxCircuit { .txs .iter() .skip(i + 1) - .find(|tx| !tx.call_data.is_empty()); + .find(|tx| !tx.call_data.is_empty() || (tx.access_list.as_ref().map_or(false, |al| !al.0.is_empty()))); config.assign_calldata_rows( &mut region, &mut offset, From e0230af3c86e179f9ef35da38c10a321b1adac97 Mon Sep 17 00:00:00 2001 From: kunxian xia Date: Wed, 29 May 2024 19:51:45 +0800 Subject: [PATCH 2/2] remove wrong constraints --- zkevm-circuits/src/tx_circuit.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/zkevm-circuits/src/tx_circuit.rs b/zkevm-circuits/src/tx_circuit.rs index 5e383a2208..fe6d68f309 100644 --- a/zkevm-circuits/src/tx_circuit.rs +++ b/zkevm-circuits/src/tx_circuit.rs @@ -923,17 +923,6 @@ impl SubCircuitConfig for TxCircuitConfig { }, ); - // AccessListAddressLen != 0 must force AccessListRLC != 0 - cb.condition( - and::expr([ - is_access_list_addresses_len(meta), - not::expr(meta.query_advice(is_none, Rotation::cur())), - ]), - |cb| { - cb.require_zero("AccessListRLC != 0", value_is_zero.expr(Rotation(2))(meta)); - }, - ); - cb.gate(meta.query_fixed(q_enable, Rotation::cur())) });