Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tx circuit errors #1303

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix: tx circuit errors #1303

merged 2 commits into from
May 29, 2024

Conversation

kunxian-xia
Copy link

Description

Issue Link

  1. The rule to find next tx in dynamic section is changed after we enable EIP2930. Previously only calldata rows are assigned in dynamic section. After EIP2930, it should be either calldata or access_list rows.

  2. The requirement that

    if a tx's access_list_address_len != 0, then its access_list_rlc must be zero.
    is wrong.

    An counterexample is like this:

    {
        "address": "0x0",
        "storage_keys": [
              "0x0",
         ]
    } 
    

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@kunxian-xia kunxian-xia requested a review from darth-cy May 29, 2024 12:00
@lispc lispc merged commit c0294ac into develop May 29, 2024
16 checks passed
@lispc lispc deleted the fix/tx-eip1559-errs branch May 29, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants