code simplification with clippy

Author: reuvenpo

packages/storage/src/append_store.rs

@@ -47,8 +47,7 @@ impl<'a, T: Serialize + DeserializeOwned, Ser: Serde> AppendStore<'a, T, Ser> {
     /// and you still get to define the AppendListStorage as a static constant
     pub fn add_suffix(&self, suffix: &[u8]) -> Self {
         let suffix = to_length_prefixed(suffix);
-        let prefix = self.prefix.as_ref().map(Vec::as_slice);
-        let prefix = prefix.unwrap_or(self.namespace);
+        let prefix = self.prefix.as_deref().unwrap_or(self.namespace);
         let prefix = [prefix, suffix.as_slice()].concat();
         Self {
             namespace: self.namespace,

packages/storage/src/deque_store.rs

@@ -51,8 +51,7 @@ impl<'a, T: Serialize + DeserializeOwned, Ser: Serde> DequeStore<'a, T, Ser> {
     /// and you still get to define the DequeStorage as a static constant
     pub fn add_suffix(&self, suffix: &[u8]) -> Self {
         let suffix = to_length_prefixed(suffix);
-        let prefix = self.prefix.as_ref().map(Vec::as_slice);
-        let prefix = prefix.unwrap_or(self.namespace);
+        let prefix = self.prefix.as_deref().unwrap_or(self.namespace);
         let prefix = [prefix, suffix.as_slice()].concat();
         Self {
             namespace: self.namespace,

packages/storage/src/item.rs

@@ -34,8 +34,7 @@ impl<'a, T: Serialize + DeserializeOwned, Ser: Serde> Item<'a, T, Ser> {
     /// and you still get to define the Item as a static constant
     pub fn add_suffix(&self, suffix: &[u8]) -> Self {
         let suffix = to_length_prefixed(suffix);
-        let prefix = self.prefix.as_ref().map(Vec::as_slice);
-        let prefix = prefix.unwrap_or(self.storage_key);
+        let prefix = self.prefix.as_deref().unwrap_or(self.storage_key);
         let prefix = [prefix, suffix.as_slice()].concat();
         Self {
             storage_key: self.storage_key,

packages/storage/src/keymap.rs

@@ -81,8 +81,7 @@ impl<'a, K: Serialize + DeserializeOwned, T: Serialize + DeserializeOwned, Ser:
     /// and you still get to define the Keymap as a static constant
     pub fn add_suffix(&self, suffix: &[u8]) -> Self {
         let suffix = to_length_prefixed(suffix);
-        let prefix = self.prefix.as_ref().map(Vec::as_slice);
-        let prefix = prefix.unwrap_or(self.namespace);
+        let prefix = self.prefix.as_deref().unwrap_or(self.namespace);
         let prefix = [prefix, suffix.as_slice()].concat();
         Self {
             namespace: self.namespace,