You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of scanpy.
(optional) I have confirmed this bug exists on the main branch of scanpy.
What happened?
This isn't so much a bug as it doesn't have an impact on runtime behavior as a "we should be more careful because it could change" (dask ignores this when returning data and just returns the actually computed data, which is floating point)
The output dtype of the PCA should be float, not that of the underlying data so we should likely add an argument or repurpose the dtype_ attribute to reflect this
This same issue is present in the covariance calculation
Minimal code sample
N/A
Error output
N/A
Versions
N/A
The text was updated successfully, but these errors were encountered:
Please make sure these conditions are met
What happened?
This isn't so much a bug as it doesn't have an impact on runtime behavior as a "we should be more careful because it could change" (dask ignores this when returning data and just returns the actually computed data, which is floating point)
scanpy/src/scanpy/preprocessing/_pca/_dask_sparse.py
Lines 129 to 137 in f6a665b
The output
dtype
of the PCA should be float, not that of the underlying data so we should likely add an argument or repurpose thedtype_
attribute to reflect thisThis same issue is present in the covariance calculation
Minimal code sample
Error output
Versions
N/A
The text was updated successfully, but these errors were encountered: