Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role writes files to local disk and relies on that state in subsequent runs #272

Open
lattwood opened this issue Jul 28, 2023 · 0 comments

Comments

@lattwood
Copy link

Issue

The roles in this repo treat the place they're being run from as a pet. They do a lot of delegate_to: localhost for generating/storing files, and the roles themselves tend to have inputs as paths on the machine running the ansible-playbook command.

It would be preferable to pass everything in as a role input, as this would prevent accidentally committing secrets to git. This would require more initial setup work by anyone looking to use the role in their infrastructure to ensure they call the role correctly, as well as generate secrets and store them.

Passing things in as a role input would provide for the flexibility to fetch values from a secure secret storage mechanism as they would all be subject to jinja2 templating etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant