Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose expected sample rate in models #57

Closed
sdatkinson opened this issue Jun 22, 2023 · 0 comments · Fixed by #60
Closed

Expose expected sample rate in models #57

sdatkinson opened this issue Jun 22, 2023 · 0 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@sdatkinson
Copy link
Owner

This Issue is for models to expose a getter, .GetExpectedSampleRate(), so that interfacing code can understand what the ML models implicitly expect to receive.

Since get_dsp is part of this repo, we are in charge of deciding what to do if no sample rate is recorded as part of the model (i.e. from .nam files pre-sdatkinson/neural-amp-modeler#284). In this case, I will return -1.0, and this will be defined to mean "We don't know." (NeuralAmpModelerPlugin will take this to mean that it must be the implicit default from earlier, 48kHz; others are free to do as they'd like, though this will likely be what they want to do as well assuming they're building for the same user ecosystem.)

The semantics are also that this is the expected sample rate--there's nothing artistically wrong with disregarding it, and this is an artist's tool at the end of the day 🙂

@sdatkinson sdatkinson added the enhancement New feature or request label Jun 22, 2023
@sdatkinson sdatkinson self-assigned this Jun 22, 2023
@sdatkinson sdatkinson changed the title Expose expected samlpe rate in models Expose expected sample rate in models Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant