Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different sample rates and bit depths (training) #13

Closed
sdatkinson opened this issue May 4, 2022 · 4 comments · Fixed by #332
Closed

Different sample rates and bit depths (training) #13

sdatkinson opened this issue May 4, 2022 · 4 comments · Fixed by #332
Assignees
@sdatkinson
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sdatkinson
Copy link
Owner

Currently locked it into 48kHz/24-bit just to make sure I don't make mistakes, but this shouldn't need to be the case.
@sdatkinson sdatkinson added the enhancement New feature or request label May 4, 2022
@sdatkinson
Copy link
Owner Author

Also related--handle this for the plugin.

@38github
Copy link

38github commented Mar 2, 2023

Will there be any issues with mismatching sample rates (project vs model sample rates)? I know other plugins that have problems with that and creates unwanted frequencies, i.e. GuitarML's SmartPedal and Proteus. Chowdhury's implementation of Proteus (LSTM) has a fix for that in an upcoming release.

Chowdhury-DSP/BYOD#250

@sdatkinson sdatkinson mentioned this issue Apr 8, 2023
Closed
@2-dor
Copy link

2-dor commented Apr 24, 2023

Hi Steve. Any chance this one could make it up the priorities list?
Thank you.

@smallbutfine
Copy link

A sox or ffmpeg one-liner could easily convert to the appropriate format.

@sdatkinson sdatkinson added the good first issue Good for newcomers label May 24, 2023
@sdatkinson sdatkinson self-assigned this Nov 7, 2023
This was referenced Nov 7, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdatkinson sdatkinson

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Allow non-48k, non-24-bit training data sdatkinson/neural-amp-modeler
4 participants
@sdatkinson @38github @smallbutfine @2-dor