-
Notifications
You must be signed in to change notification settings - Fork 280
Comparing changes
Open a pull request
base repository: sds/overcommit
base: v0.28.0
head repository: sds/overcommit
compare: main
Commits on Aug 26, 2015
-
Add Pylint to list of pre-commit hooks
We have a hook for this, but it was mysteriously absent from this list.
Configuration menu - View commit details
-
Copy full SHA for e26ae1c - Browse repository at this point
Copy the full SHA e26ae1cView commit details
Commits on Sep 5, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 12093b1 - Browse repository at this point
Copy the full SHA 12093b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeb8bdc - Browse repository at this point
Copy the full SHA eeb8bdcView commit details
Commits on Sep 8, 2015
-
Allow nested arrays in include/exclude options
This allows us to use YAML references to extend a default list of exclusions without repeating ourselves, while still being explicit about where the exclusions are coming from in the YAML file.
Configuration menu - View commit details
-
Copy full SHA for c7471ec - Browse repository at this point
Copy the full SHA c7471ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for da7955d - Browse repository at this point
Copy the full SHA da7955dView commit details
Commits on Sep 15, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 14d0a45 - Browse repository at this point
Copy the full SHA 14d0a45View commit details
Commits on Sep 17, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 51d0348 - Browse repository at this point
Copy the full SHA 51d0348View commit details
Commits on Sep 23, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 9774d2b - Browse repository at this point
Copy the full SHA 9774d2bView commit details
Commits on Sep 30, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 311f73f - Browse repository at this point
Copy the full SHA 311f73fView commit details -
Mention
OVERCOMMIT_DEBUG=1
in CONTRIBUTING.mdIn 0.27.0 we added support for the `OVERCOMMIT_DEBUG` environment variable which toggles the display of verbose output from executed commands, but didn't document it anywhere. This setting might help people debug their problems and submit more informative bug reports, so documenting it here seems to make sense.
Configuration menu - View commit details
-
Copy full SHA for 98c712c - Browse repository at this point
Copy the full SHA 98c712cView commit details
Commits on Oct 1, 2015
-
Configuration menu - View commit details
-
Copy full SHA for e3ad967 - Browse repository at this point
Copy the full SHA e3ad967View commit details
Commits on Oct 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for e2b527d - Browse repository at this point
Copy the full SHA e2b527dView commit details
Commits on Oct 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 03c1f49 - Browse repository at this point
Copy the full SHA 03c1f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0b5993 - Browse repository at this point
Copy the full SHA d0b5993View commit details
Commits on Oct 15, 2015
-
Fix tests with git diff.renames option set
If the ~/.gitconfig sets the `diff.renames` option to a true value 4 of the 5 tests run with `rspec -d renam` fail. Fix this by adding `R` to the list of change types included in the `--diff-filter` option. All tests continue to pass if this option is left at the default value.
Configuration menu - View commit details
-
Copy full SHA for f2ab408 - Browse repository at this point
Copy the full SHA f2ab408View commit details
Commits on Oct 22, 2015
-
Add GitConfig.comment_character method
Retrieve the character which git will use to indicate comments in commit message templates.
Configuration menu - View commit details
-
Copy full SHA for 6245b56 - Browse repository at this point
Copy the full SHA 6245b56View commit details -
Honor
core.commentchar
configurationModify commit message parsing to respect the comment character which git has been configured to use.
Configuration menu - View commit details
-
Copy full SHA for 007bc87 - Browse repository at this point
Copy the full SHA 007bc87View commit details
Commits on Oct 23, 2015
-
Configuration menu - View commit details
-
Copy full SHA for d411541 - Browse repository at this point
Copy the full SHA d411541View commit details
Commits on Oct 28, 2015
-
This has confused some people since the name was changed to match Rubygems naming conventions. Ensure we document the underscored name.
Configuration menu - View commit details
-
Copy full SHA for 7173482 - Browse repository at this point
Copy the full SHA 7173482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59fb6ed - Browse repository at this point
Copy the full SHA 59fb6edView commit details
Commits on Nov 18, 2015
-
Sign configuration in addition to hook plugins
Unfortunately, the hook signing code did not work as advertised. Since we weren't signing the configuration file itself, an attacker could change the value of `verify_plugin_signatures` to `false` at the same time they added some malicious code, thereby bypassing the check altogether. Work around this by signing the configuration file itself. In order to force everyone's attention (and also to reflect the fact that this signing doesn't only apply to hooks) change the option name to `verify_signatures`. The default is `true`, so developers will have to update their configuration to the new `verify_signatures` option. Hopefully this will prompt organizations to read the change log and perform an audit of their repository hooks. This implementation is a little bit tangly, but I erred on the side of having it more global in scope so that any disabling of verification is intentional rather than because we forgot to enable it for a particular code path.
Configuration menu - View commit details
-
Copy full SHA for 6271bfa - Browse repository at this point
Copy the full SHA 6271bfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fddb5cf - Browse repository at this point
Copy the full SHA fddb5cfView commit details -
Sign hooks before executing with --run flag in Travis
Our new signing logic requires us to sign on the first run. Since this is running in CI, we're OK signing without manually verifying.
Configuration menu - View commit details
-
Copy full SHA for bcb41f9 - Browse repository at this point
Copy the full SHA bcb41f9View commit details -
We recently had an issue filed where the user was confused about whether underscores were allowed in a hook's name. Rather than document this, simply raise an error, since we need to enforce hook names as CamelCase in order to have a one-way mapping between CamelCase and snake_case and vice versa.
Configuration menu - View commit details
-
Copy full SHA for 4e17d61 - Browse repository at this point
Copy the full SHA 4e17d61View commit details -
Fix hook signing when specifying name
Unfortunately the fix in 6271bfa broke hook signing (specifically when you specified a name). Fix it.
Configuration menu - View commit details
-
Copy full SHA for fbab8c0 - Browse repository at this point
Copy the full SHA fbab8c0View commit details -
Fix BundleCheck hook to work with --run flag with local changes
As reported in #293, this hook would fail if you ran Overcommit via the `--run` flag with local changes that weren't staged, resulting in `git diff -- Gemfile.lock` always exiting unsuccessfully. Work around this by reading the contents of the file before and after, and raise an error if its content changes.
Configuration menu - View commit details
-
Copy full SHA for ed0fc9c - Browse repository at this point
Copy the full SHA ed0fc9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f248a83 - Browse repository at this point
Copy the full SHA f248a83View commit details -
Configuration menu - View commit details
-
Copy full SHA for d555521 - Browse repository at this point
Copy the full SHA d555521View commit details
Commits on Nov 19, 2015
-
Configuration menu - View commit details
-
Copy full SHA for b3f66a3 - Browse repository at this point
Copy the full SHA b3f66a3View commit details
Commits on Nov 21, 2015
-
Fix --run flag to work with ad hoc hook scripts
When attempting to use an existing hook script (a.k.a. ad hoc hooks) with the `--run` flag, the hook would block reading on STDIN (since there was nothing to read). Since pre-commit hooks don't read from STDIN anyway, pass in the null input stream to ensure we don't block.
Configuration menu - View commit details
-
Copy full SHA for 9778b29 - Browse repository at this point
Copy the full SHA 9778b29View commit details -
Specify branch in build status badge
Apparently this shows the status of all branches by default. Limit it to the master build so pull requests don't mess things up.
Configuration menu - View commit details
-
Copy full SHA for b102f3e - Browse repository at this point
Copy the full SHA b102f3eView commit details
Commits on Nov 22, 2015
-
Increase timeout for --run flag integration test
The test fails on JRuby because it takes longer than a second to start up Overcommit on the JVM. Increase the timeout to 10 seconds to be safe.
Configuration menu - View commit details
-
Copy full SHA for 4db026a - Browse repository at this point
Copy the full SHA 4db026aView commit details -
Add Dogma pre-commit hook to check Elixir source files
Dogma is a code style linter for Elixir language. Dogma's source code is available at https://github.com/lpil/dogma This pre-commit hook executes dogma and reports errors.
Configuration menu - View commit details
-
Copy full SHA for 1d392fa - Browse repository at this point
Copy the full SHA 1d392faView commit details
Commits on Nov 24, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 6b589aa - Browse repository at this point
Copy the full SHA 6b589aaView commit details
Commits on Nov 25, 2015
-
Configuration menu - View commit details
-
Copy full SHA for bd6d096 - Browse repository at this point
Copy the full SHA bd6d096View commit details -
Configuration menu - View commit details
-
Copy full SHA for d824f8a - Browse repository at this point
Copy the full SHA d824f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for daff6eb - Browse repository at this point
Copy the full SHA daff6ebView commit details
Commits on Dec 15, 2015
-
Configuration menu - View commit details
-
Copy full SHA for ed26f3c - Browse repository at this point
Copy the full SHA ed26f3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee28194 - Browse repository at this point
Copy the full SHA ee28194View commit details -
Correctly fail hook when rubocop is not installed
When rubocop is not installed, or when the installed version does not match the version expected by Bundler, the 'pre_commit/rubo_cop' hook passes 100% of the time because 'result.stdout' is empty. This commit updates the hook to fail if anything is present in stderr after the hook runs.
Configuration menu - View commit details
-
Copy full SHA for efa40dc - Browse repository at this point
Copy the full SHA efa40dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c06d2af - Browse repository at this point
Copy the full SHA c06d2afView commit details
Commits on Dec 18, 2015
-
Configuration menu - View commit details
-
Copy full SHA for ef36c65 - Browse repository at this point
Copy the full SHA ef36c65View commit details
Commits on Dec 23, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c5f145c - Browse repository at this point
Copy the full SHA c5f145cView commit details -
Add example to commit-msg TextWidth hook
Add example verifying that lines in the commit message are allowed to be the length of the limit plus a trailing newline character.
Configuration menu - View commit details
-
Copy full SHA for c7223dc - Browse repository at this point
Copy the full SHA c7223dcView commit details -
Don't count newline against commit subject length
When comparing the commit subject against the specified limit, trailing newlines should not be considered part of a subject's character count.
Configuration menu - View commit details
-
Copy full SHA for 44fc645 - Browse repository at this point
Copy the full SHA 44fc645View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd7aa39 - Browse repository at this point
Copy the full SHA bd7aa39View commit details -
Fix TextWidth spec for Ruby 1.9.3
The test was failing since `#lines` returns an Enumerator in 1.9.3. Ensure it is an array.
Configuration menu - View commit details
-
Copy full SHA for ef693fb - Browse repository at this point
Copy the full SHA ef693fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9f013 - Browse repository at this point
Copy the full SHA 0d9f013View commit details -
Configuration menu - View commit details
-
Copy full SHA for eda2813 - Browse repository at this point
Copy the full SHA eda2813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08cf3fc - Browse repository at this point
Copy the full SHA 08cf3fcView commit details
There are no files selected for viewing
This file was deleted.