Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle-audit: consider always updating ruby-advisory-db when running the check #812

Open
pjpires opened this issue May 18, 2023 · 0 comments

Comments

@pjpires
Copy link

pjpires commented May 18, 2023

Recently I found I needed to update a few patch versions of rails-related libraries in a project, due to some security updates available. However, they were not reported when running overcommit with bundle-audit enabled.

From my understanding the issue is that bundle-audit was running against an outdated list of vulnerabilities. It can be fixed by passing the --update flag when running the check, as documented here.

In my opinion, this should be the default behavior. Is it worth it to open a PR that sets that flag by default in https://github.com/sds/overcommit/blob/master/config/default.yml?

By the way, thanks for the great work! 👏 We've been using overcommit across a variety of projects for a long time now, it improved our workflow a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant