Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for probes and checks. #17

Open
vrongmeal opened this issue Dec 26, 2019 · 2 comments
Open

Add unit tests for probes and checks. #17

vrongmeal opened this issue Dec 26, 2019 · 2 comments
Labels
testing Related to testing of code.

Comments

@vrongmeal
Copy link
Contributor

All the checks rely on various user inputs and can encounter many corner cases. Probes may encounter some race conditions as well. Writing tests is required for the same.

@vrongmeal vrongmeal added the testing Related to testing of code. label Dec 26, 2019
@fristonio
Copy link
Member

While adding tests is good, I want to know where can we encounter race conditions in the probes?

@vrongmeal
Copy link
Contributor Author

That I wrote in context with the websocket probe. The way i implemented it first had some issues but I changed it. Anyhow, yeah, we should write tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to testing of code.
Projects
None yet
Development

No branches or pull requests

2 participants