[#25] - Added answers for conclusion #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruishanteo
reviewed
Aug 18, 2024
tutorials/ab3TracingCode.md
Outdated
|
|
||
| <box type="info" seamless> | ||
|
|
||
| Remember to update other usages of `DeleteCommand` class to handle the change in type of Index. |
There was a problem hiding this comment.
Hi, really comprehensive answers here!
Just a nit: 'to handle the change in type of argument' might be better, I think.
ruishanteo
reviewed
Aug 18, 2024
tutorials/ab3TracingCode.md
Outdated
| * No exception thrown. | ||
| * Reason: The command is correctly formatted and will edit the tags of the person at index 1 to "one", "two" and "three". | ||
|
|
||
| <panel header="Why didn’t the second tag with value “one” get added?"> |
There was a problem hiding this comment.
I think instead of a panel inside a panel, it would be better if the additional information was presented in an info box instead.
And the question could be made clearer: Why aren't there two tags with value "one" after this command is executed?
Lastly, would this be more accurate?
... ParserUtil#parseTags() method when tags are added to a HashSet...
What do you think?
There was a problem hiding this comment.
Thanks for the suggestion! Agreed that an info box would be clearer for the reader. Made the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25