-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add importing gradle project for vscode #87
Add importing gradle project for vscode #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ruishan, I followed your tutorial and successfully set up Gradle on AB3 in VS Code. I have a few minor suggestions that could help further improve the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ruishan, I’ve proposed my suggestions to give you a better understanding of my vision for the comments. Let me know if anything needs further clarification!
Co-authored-by: Carlin Tan <[email protected]>
Co-authored-by: Carlin Tan <[email protected]>
Co-authored-by: Carlin Tan <[email protected]>
Co-authored-by: Carlin Tan <[email protected]>
tutorials/vscode.md
Outdated
4. After the importing of the project is complete (which could take a few minutes), you will see the Gradle Tab in the VSCode interface e.g., look for the elephant icon on the left and click it. | ||
|
||
<img width="258" alt="grade-icon-vscode" src="https://github.com/user-attachments/assets/1280c200-8301-4a5d-8e37-5bbafb321541"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruishanteo commit images as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the image
Okay, thank you for the comments and the suggested edits! I have committed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, succinct and clear guide to setting up Gradle in VSCode. Just some minor suggestions.
i. Select the project directory, and click Open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the intended step-by-step approach to indicate opening a file. However, when I first read it, I was slightly confused with all the 'Open's. Perhaps for just opening the project, we could tell the reader to "Open your project via Open Folder or File -> Open. Then select your project folder and click open." rather than have a (i) point for it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a nice touch that personalises to the reader and makes it more convenient!
**Note:** MacOS users need to download Azul Zulu compatible with their machine and Java 17, with the Java Package specified as JDK FX. | ||
|
||
(b) Confirm the correct JVM is used for Gradle, as given in the panel below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can quickly define JVM (or just spell out first) as the context doesn't provide much of a hint to first-time Java users?
Thanks for this PR @ruishanteo |
Fixes #54