Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importing gradle project for vscode #87

Closed

Conversation

ruishanteo
Copy link

Fixes #54

Copy link

@Carlintyj Carlintyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ruishan, I followed your tutorial and successfully set up Gradle on AB3 in VS Code. I have a few minor suggestions that could help further improve the pull request.

tutorials/vscode.md Outdated Show resolved Hide resolved
tutorials/vscode.md Outdated Show resolved Hide resolved
tutorials/vscode.md Outdated Show resolved Hide resolved
tutorials/vscode.md Show resolved Hide resolved
tutorials/vscode.md Show resolved Hide resolved
Copy link

@Carlintyj Carlintyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ruishan, I’ve proposed my suggestions to give you a better understanding of my vision for the comments. Let me know if anything needs further clarification!

tutorials/vscode.md Outdated Show resolved Hide resolved
tutorials/vscode.md Outdated Show resolved Hide resolved
tutorials/vscode.md Show resolved Hide resolved
tutorials/vscode.md Show resolved Hide resolved
4. After the importing of the project is complete (which could take a few minutes), you will see the Gradle Tab in the VSCode interface e.g., look for the elephant icon on the left and click it.

<img width="258" alt="grade-icon-vscode" src="https://github.com/user-attachments/assets/1280c200-8301-4a5d-8e37-5bbafb321541">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruishanteo commit images as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the image

@ruishanteo
Copy link
Author

Hi Ruishan, I’ve proposed my suggestions to give you a better understanding of my vision for the comments. Let me know if anything needs further clarification!

Okay, thank you for the comments and the suggested edits! I have committed them.

Copy link

@gongg21 gongg21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, succinct and clear guide to setting up Gradle in VSCode. Just some minor suggestions.

Comment on lines +29 to +30
i. Select the project directory, and click Open.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the intended step-by-step approach to indicate opening a file. However, when I first read it, I was slightly confused with all the 'Open's. Perhaps for just opening the project, we could tell the reader to "Open your project via Open Folder or File -> Open. Then select your project folder and click open." rather than have a (i) point for it.

Comment on lines +36 to +37

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a nice touch that personalises to the reader and makes it more convenient!

**Note:** MacOS users need to download Azul Zulu compatible with their machine and Java 17, with the Java Package specified as JDK FX.

(b) Confirm the correct JVM is used for Gradle, as given in the panel below:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can quickly define JVM (or just spell out first) as the context doesn't provide much of a hint to first-time Java users?

damithc pushed a commit that referenced this pull request Sep 29, 2024
@damithc
Copy link
Contributor

damithc commented Sep 29, 2024

Thanks for this PR @ruishanteo
I've adapted its content in this commit 5609208

@damithc damithc closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to VSCode guide
4 participants