Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve construction of multi-relation networks #119

Open
clhunsen opened this issue May 2, 2018 · 2 comments
Open

Improve construction of multi-relation networks #119

clhunsen opened this issue May 2, 2018 · 2 comments
Assignees
Milestone

Comments

@clhunsen
Copy link
Collaborator

clhunsen commented May 2, 2018

Description

The construction of multi-relation networks is quite complex in the sense of run-time overhead: We construct the separate networks (by constructing edge lists and, then, networks), transform these to edge lists again, merge them, and construct a merged network in the end. Instead, we should construct edge lists, merge those, and construct a network only once – and improve the run-time for complex and large networks!

Thus, we need to merge edge lists instead of networks here and here.

In the end, we may end up having the private network-construction methods (such as get.author.network.cochange()) returning a similar value as the function construct.edge.list.from.key.value.list().

Versions

This affects the upcoming version v3.2 as it contains the code of PR #115.

@clhunsen clhunsen added this to the Future milestone May 2, 2018
@clhunsen
Copy link
Collaborator Author

clhunsen commented May 2, 2018

As a first step, we may want to check whether there is only one relation present in the network configuration, then only merge if there are more than one. This is basically a patch analogous to the function simplify.network:

https://github.com/se-passau/codeface-extraction-r/blob/ef094eb7e94691e2a29a8e0f598e514947ebd6b8/util-networks.R#L1168

@clhunsen clhunsen modified the milestones: Future, v3.6 Jul 17, 2019
@clhunsen
Copy link
Collaborator Author

As a first step, we may want to check whether there is only one relation present in the network configuration, then only merge if there are more than one. This is basically a patch analogous to the function simplify.network:

https://github.com/se-passau/codeface-extraction-r/blob/ef094eb7e94691e2a29a8e0f598e514947ebd6b8/util-networks.R#L1168

This is fixed in commit 0666f1f#diff-7a643d3b27ce60a62055308f46770341R1128-R1132.

@clhunsen clhunsen self-assigned this Jan 31, 2020
@bockthom bockthom modified the milestones: v3.6, v3.7 Feb 21, 2020
clhunsen added a commit to clhunsen/coronet that referenced this issue Feb 21, 2020
Signed-off-by: Claus Hunsen <[email protected]>
clhunsen added a commit to clhunsen/coronet that referenced this issue Nov 18, 2020
Signed-off-by: Claus Hunsen <[email protected]>
@bockthom bockthom modified the milestones: v3.7, v3.8 Dec 1, 2020
@bockthom bockthom modified the milestones: v3.8, v3.9 Apr 30, 2021
@bockthom bockthom modified the milestones: v4.1, v4.2 Mar 24, 2022
@bockthom bockthom modified the milestones: v4.2, v4.3 Oct 28, 2022
@bockthom bockthom modified the milestones: v4.3, v4.4 Apr 17, 2023
@bockthom bockthom modified the milestones: v4.4, v4.5 Mar 22, 2024
@bockthom bockthom assigned maxloeffler and unassigned fehnkera Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants