Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in screen can be accessed while logged in #156

Open
2 of 6 tasks
timovv opened this issue Apr 23, 2020 · 0 comments
Open
2 of 6 tasks

Log in screen can be accessed while logged in #156

timovv opened this issue Apr 23, 2020 · 0 comments
Labels
front-end Issues related to front-end development seeking-approval

Comments

@timovv
Copy link
Collaborator

timovv commented Apr 23, 2020

Describe the bug
While logged in, if I try and go to the login screen (at /), the screen is presented so that I can log in as someone else. If I log in as someone else, I am logged out
To Reproduce
Steps to reproduce behaviour:

  1. Log in to application
  2. Return to / path by changing browser URL
  3. Observe that login screen is available, even though I should in theory be logged in.

Severity
Mark with an x.

  • Minor effect eg. graphical
  • Functional error eg. App does not function correctly
  • Severe eg. Crashing

Reproducibility
Mark with an x.

  • Consistent
  • Occasional
  • Cannot reproduce at the moment eg. unsure

Expected behavior
I cannot access the login screen while logged in, and must log in to do this.

I suggest that we solve this issue by removing the /home part of the route for the logged in part of the application and serving everything there directly from / (i.e. also /transactions instead of /home/transactions and so on) and while the user is logged in. This would mean that the log in screen is not accessible, and the routing would look cleaner.

Screenshots, Images and Traces
Not applicable

Conditions
Tested on Windows with Chromium-based Edge but this should be reproducible on any browser.

Issue Dependencies
Related to #141.

Also, this shouldn't be fixed unless #142 is addressed. Otherwise, the user would not be able to log in as anybody else once logged in, since they can't currently actually sign out.

Additional context
Not applicable

@timovv timovv added front-end Issues related to front-end development seeking-approval labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issues related to front-end development seeking-approval
Projects
None yet
Development

No branches or pull requests

1 participant