Syntatic Feature Extraction #11
Conversation
There was a problem hiding this comment.
remove this change since this is not a part of this issue
There was a problem hiding this comment.
please include the updated feature_data.csv as well
| @@ -34,6 +34,16 @@ | |||
| // feature 10: #literals | |||
| private int literals = 0; | |||
|
|
|||
| // new features | |||
| private float avgCommas = 0.0f; | |||
There was a problem hiding this comment.
No need to use 0.0f - because Java supports Auto casting.
float avgCommas = 0 will work.
| features.setParenthesis(count(snippet, "\\(") * 2); | ||
|
|
||
| //get the number of lines of code | ||
| String[] lines = snippet.split("\n"); |
There was a problem hiding this comment.
This will include empty lines as well. Instead use SCC tool to get the lines of code (!empty+!comment lines)
| @@ -83,4 +84,7 @@ public void testIfStatements2() { | |||
| public void testMethodParameters2() { | |||
| assertEquals(NUM_OF_PARAMETERS_2, featureVisitor2.getFeatures().getNumOfParameters()); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@zeesoolee Overall good job! A couple of comments.
- Let's use a separate file - say something like
aggregated_feature_extractorto collect features that include LOC (lines of code). LOC can be obtained from the loc_data.csv. - Update unit tests to test your feature.
- Always mention the GH issue Id in your PR description. - this is a good practice to link issues and corresponding fix
|
@zeesoolee / @zslee001 closed this PR since the fork of this implementation is now outdated. But the comments mentioned here should be addressed in your new PR. And link this PR's ID in your new PR. |
Syntatic Feature Extraction, some progress on new features