Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Code Sample/PHP): update response type to be php #60

Closed
mikewuu opened this issue Aug 13, 2024 · 3 comments · Fixed by #80
Closed

fix(Code Sample/PHP): update response type to be php #60

mikewuu opened this issue Aug 13, 2024 · 3 comments · Fixed by #80
Assignees

Comments

@mikewuu
Copy link
Contributor

mikewuu commented Aug 13, 2024

Not for this PR, but this really should be php

Originally posted by @razor-x in #58 (comment)

@razor-x
Copy link
Collaborator

razor-x commented Aug 13, 2024

@andrii-balitskyi Was the json response type for PHP intentional? Isn't there a PHP class for each resource?

@andrii-balitskyi
Copy link
Contributor

andrii-balitskyi commented Sep 4, 2024

@razor-x Yes, you're right, there's a class for each resource. I was referencing our current docs where we put JSON in the PHP response example. My bad.
I'm not sure how a PHP-style response should look.
Something like this looks a bit messy:
?

@razor-x
Copy link
Collaborator

razor-x commented Sep 4, 2024

@andrii-balitskyi For rendering the response for each language, let's use the primitive literal syntax. I realize the actual return value is a wrapper data class, but it's not possible to format that via a formatter, and it can't be copy-pasted into an interpreter.

So for PHP, this would be

[
    "connected_account_id" => "...",
    "is_managed" => True,
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants