Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #65

Open
sean-hale-dev opened this issue Apr 25, 2021 · 0 comments
Open

Code Cleanup #65

sean-hale-dev opened this issue Apr 25, 2021 · 0 comments
Assignees
@technostarbtd5 @sean-hale-dev @litala123
Labels
API back end Something for the project back end front end Something for the project front end help wanted Extra attention is needed

Comments

@sean-hale-dev
Copy link
Owner

There are a few things that code cleanup should entail:

  • Functional comments/Commenting any confusing login
  • Delete console.log() and commented code blocks
  • Frontend Only axios requests to "window.location.hostname:8080" will not work in deployment. Please change these to just the api path (package.json's proxy field will handle proxying to the backend during development). For example change "window.location.hostname:8080/api/resume-download" to "/api/resume-download"
@sean-hale-dev sean-hale-dev added help wanted Extra attention is needed front end Something for the project front end back end Something for the project back end API labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technostarbtd5 technostarbtd5

@sean-hale-dev sean-hale-dev

@litala123 litala123

Labels
API back end Something for the project back end front end Something for the project front end help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@technostarbtd5 @sean-hale-dev @litala123