-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmark swipe UI is preventing access to transliteration tooltips #35
Comments
It looks like this issue is difficult/impossible to resolve if maintaining the current approach of an overlay with the swipe listeners. See this open issue: Click or tap through swipeable component. Moving the overlay to the margin(s)Instead of having a full screen swipe overlay, the overlay could be positioned to cover only the left margin of the page (or both margins). This would mean swiping has to start right at the very edge of the screen to add/remove bookmarks. Edit: This actually isn't a practical solution, since Chromium browsers interpret swipes from the left or right sides as back or forward directives respectively. Removing the overlayMoving the swipe event listeners to the parent element of the text resolves this issue, as the overlay no longer blocks the swipe, and events can bubble up through the HTML hierarchy as expected. So, can the swipe overlay be removed? It was added during the initial implementation (#27) to provide an easy method of disabling the swipe interface on larger screens (with a media query and The The
|
As a solution to the main problem, the bookmark swipe overlay has been removed, with the swipe event listeners instead being attached to the outer container of As described above, this will require a slightly different approach to responsive CSS that considers not only screen width, but also device type via the hover media query. A new issue (#38) has been raised to deal with the implementation of this styling. |
Description
This is a crucial bug - on mobile it's no longer possible to access the transliteration tooltips with a tap. This is because the swipe handling layer on top is intercepting touch events.
The text was updated successfully, but these errors were encountered: