Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC4E data is missing many packages #4

Open
Zasco opened this issue Dec 25, 2024 · 5 comments
Open

SC4E data is missing many packages #4

Zasco opened this issue Dec 25, 2024 · 5 comments

Comments

@Zasco
Copy link
Contributor

Zasco commented Dec 25, 2024

In sc4e.js.
Just PRed two in #3.
I realized 36 : lowkee33:seasonal-flora-patch-maxis also is missing. Led me to believe there is more.
I use these for my browser extension project.

@sebamarynissen
Copy link
Owner

Yeah, the list is incomplete because I only fill in new ones "on the go" whenever I run into them when adding packages to the default channel (such as in memo33/sc4pac#50 or memo33/sc4pac#54)
Feel free to create PRs for them filling in the gaps!

@memo33
Copy link

memo33 commented Dec 28, 2024

Note that you can obtain these IDs directly from the sc4pac-channel-contents.json file:

{
 "packages": [
  {
   "group": "lowkee33",
   "name": "seasonal-flora-patch-maxis",
   "externalIds": { "sc4e": ["36"] },
   
  },
  

@Zasco
Copy link
Contributor Author

Zasco commented Dec 28, 2024

Note that you can obtain these IDs directly from the sc4pac-channel-contents.json file:

{
 "packages": [
  {
   "group": "lowkee33",
   "name": "seasonal-flora-patch-maxis",
   "externalIds": { "sc4e": ["36"] },
   
  },
  

Great! Is this new? I don't recall having seen this.

@memo33
Copy link

memo33 commented Dec 29, 2024 via email

@Zasco
Copy link
Contributor Author

Zasco commented Dec 29, 2024

It's quite new. It was added with sc4pac 0.5.0.

Great! I must have overlooked it. I'll change my logic as this is more complete/reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants