From 191fc8d8b213fceb454dbedecfc674c8ec8f2c5b Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Tue, 29 Oct 2024 20:16:20 +0100 Subject: [PATCH] Perf optimize StringUtil --- src/StringUtil.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/StringUtil.php b/src/StringUtil.php index 0364ed9..bc4ccae 100644 --- a/src/StringUtil.php +++ b/src/StringUtil.php @@ -9,7 +9,6 @@ */ namespace SebastianBergmann\Comparator; -use function str_replace; use function strlen; use function substr; @@ -31,8 +30,8 @@ public static function removeOverlongCommonPrefix(string $string1, string $strin $commonPrefix = self::findCommonPrefix($string1, $string2); if (strlen($commonPrefix) > self::OVERLONG_PREFIX_THRESHOLD) { - $string1 = str_replace(substr($commonPrefix, 0, -self::KEEP_PREFIX_CHARS), '...', $string1); - $string2 = str_replace(substr($commonPrefix, 0, -self::KEEP_PREFIX_CHARS), '...', $string2); + $string1 = '...' . substr($string1, strlen($commonPrefix) - self::KEEP_PREFIX_CHARS); + $string2 = '...' . substr($string2, strlen($commonPrefix) - self::KEEP_PREFIX_CHARS); } return [$string1, $string2];