Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports stalled even when transferring at >500kbyte/s #33

Open
fastcat opened this issue Feb 20, 2014 · 1 comment
Open

Reports stalled even when transferring at >500kbyte/s #33

fastcat opened this issue Feb 20, 2014 · 1 comment

Comments

@fastcat
Copy link
Contributor

fastcat commented Feb 20, 2014

I've noticed yafc (debian 1.3.1-2) seems to have broken "stalled" logic. During transfers that are proceeding just fine (often quite fast), the transfer progress bar flickers many times per second between the progress and a transfer rate, and the progress with a stalled message.

@fastcat
Copy link
Contributor Author

fastcat commented Feb 20, 2014

From a quick review of the source, I think I've found the bug:

in plain-socket.c, it sets tv.tv_usec = 500, with a comment of "wait max 0.5 second". Well, 500 usec is NOT 0.5 seconds, it's 0.5 milliseconds! It should be tv.tv_usec = 500000;

fastcat added a commit to fastcat/yafc that referenced this issue Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant