From b322bc523b2b8d7bf69eae83037b2d098f4618b9 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Fri, 16 Aug 2024 16:45:18 +0200 Subject: [PATCH] shadowserver collector: fix reports = '' behaviour it the parameter is an empty string (or only contains whitespace), behave as if the parameter is not set and select all reports fixes https://github.com/certtools/intelmq/issues/2521 --- intelmq/bots/collectors/shadowserver/collector_reports_api.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/intelmq/bots/collectors/shadowserver/collector_reports_api.py b/intelmq/bots/collectors/shadowserver/collector_reports_api.py index 20f6dd73a..3fc3d2f9f 100644 --- a/intelmq/bots/collectors/shadowserver/collector_reports_api.py +++ b/intelmq/bots/collectors/shadowserver/collector_reports_api.py @@ -56,7 +56,9 @@ def init(self): raise ValueError('No secret provided.') if isinstance(self.reports, str): - self._report_list = self.reports.split(',') + # if reports is an empty string (or only contains whitespace), behave as if the parameter is not set and select all reports + reports = self.reports.strip() + self._report_list = reports.split(',') if reports else [] elif isinstance(self.reports, list): self._report_list = self.reports if isinstance(self.types, str):