Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EANs can validate as ISBNs #10

Open
therrick-findaway opened this issue Jul 29, 2022 · 0 comments
Open

EANs can validate as ISBNs #10

therrick-findaway opened this issue Jul 29, 2022 · 0 comments

Comments

@therrick-findaway
Copy link

Greetings @secnot and thank you for this repo.

I have encounter an issue where the field validation fails. EANs are the barcode versions of ISBNs, and there are scenarios where these numbers can pass an ISBN check sum, but still not be valid. 6610000352289, is one such example.

stdnum contains validation for EANs as well. Could you please add this validation check to prevent this from happening? I haven't come up with a good set of conditions to be absolutely sure it's an EAN and not an ISBN and vice versa (for instance, EANs can also start with 978 so that doesn't work), but perhaps the the algorithm is different between the two and that may suffice.

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant