Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links #17

Open
MartinKavik opened this issue Jan 2, 2020 · 7 comments · Fixed by #34
Open

Broken links #17

MartinKavik opened this issue Jan 2, 2020 · 7 comments · Fixed by #34

Comments

@MartinKavik
Copy link
Member

We should add a dead-link linter to the build / deploy pipeline.

Dead-link example: https://docs.rs/seed/0.5.1/seed/fetch/struct.Request.html on https://seed-rs.org/guide/http-requests-and-state.
It should be replaced with https://docs.rs/seed/latest/seed/browser/service/fetch/index.html

  • 0.5.1 => latest (if we want to point always to the latest version)
  • fixed path
@MartinKavik
Copy link
Member Author

MartinKavik commented Jan 31, 2020

Another broken link - https://seed-rs.org/guide/routing/ => link under Url struct
Link should point to https://docs.rs/seed/0.5.1/seed/browser/url/struct.Url.html, but there is missing link to MDN doc + comment

@MartinKavik
Copy link
Member Author

Just realised that the github examples don't match the docs! master branch vs 0.5.1 branch - D'oh!
Is it possible to have the docs link to https://github.com/seed-rs/seed/tree/ instead of master? so like https://github.com/seed-rs/seed/tree/0.5.1 at the moment

@drmason13

@David-OConnor
Copy link
Member

Fixed the broken routing link in WIP PR.

@MartinKavik MartinKavik mentioned this issue Feb 3, 2020
@itsgreggreg
Copy link
Contributor

gonna work on checking / fixing the links in all the files in here: https://github.com/itsgreggreg/seed-rs.org/tree/17/doc_link_fixes/crate/guides

Feel free to assign this to me or however you guys work. I'm not working on a dead link linter tho.

@MartinKavik
Copy link
Member Author

@itsgreggreg Just create a PR and request code review, thanks!

@eopb
Copy link

eopb commented May 28, 2020

On page https://seed-rs.org/0.6.0/structure broken link orders example

@tocklime
Copy link
Contributor

Current broken links:

> Issues
   1. 404 https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7157459/
   2. 404 https://github.com/seed-rs/seed-quickstart/generate
   3. 404 https://github.com/seed-rs/seed/blob/master/examples/orders/src/lib.rs
   4. 404 https://github.com/seed-rs/seed/tree/master/examples/server_interaction

not counting localhost, example.com and crates.io (crates.io very quickly starts returning 404s when they detect fast activity).

I'm trying to see if I can put together the automation in a way which doesn't make the rest of the internet cross.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants