Support export-name property to set case-sensitive variable names #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went with |
|
Hey, sorry this took a while to get to! Would it be possible to circumvent the ignored steps:
- commands: 'echo \$someSecret'
plugins:
- seek-oss/aws-sm#v2.4.0:
env:
- export-name: someSecret
secret-id: my-secret-id
- export-name: TF_VAR_some_other_secret
secret-id: another-secret-id |
|
Probably would be, but I've moved on from the employer where I was using this plugin, sorry. I might have time one day to revisit, but no firm plans right now |
|
Closed this PR but will revisit when have time to test and have a known use-case for mixed-case variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a simple fix for #20 - that the plugin can't set lower-case or mixed-case environment variables using the
envconfiguration (it can with JSON).Specifically, this PR adds an optional way to specify an export name directly as a value, rather than a property key (because those have their case munged to UPPER_CASE when placed in
BUILDKITE_PLUGIN_*).This new supported config type looks like this:
Closes #20.