Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make website name available to template? #41

Open
deafmute1 opened this issue Sep 5, 2024 · 1 comment
Open

Make website name available to template? #41

deafmute1 opened this issue Sep 5, 2024 · 1 comment

Comments

@deafmute1
Copy link

deafmute1 commented Sep 5, 2024

Would be nice to be able to add the name of the website to tags / metadata for the purposes of grouping recipes from the same source. I see this isn't in the json schema, but shouldn't be too hard to just parse <title> from the domain's root page?

Main barrier would be that there is no existing HTML parsing in the project, but grabbing the contents of <title> seems like it could be just done with regex/string manip on the full html content - I'm not familiar with HTML parsing in JS.

Happy to PR this myself when I have a second if it would be as easy as I'm imagining, but want to check the idea is possible first.

@seethroughdev
Copy link
Owner

seethroughdev commented Sep 11, 2024

Lol. I am SO sorry @deafmute1! I am deleting my previous message. I forgot we already do add the tags. I will 100% add name in there! I think we should go with name from the https://schema.org/Recipe instead of the <title> though. Do you agree or would you prefer the HTML title?

seethroughdev added a commit that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants