Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently the app is not compatible with Kodi 19 #26

Open
Wikinaut opened this issue Feb 4, 2021 · 9 comments · May be fixed by #29
Open

Currently the app is not compatible with Kodi 19 #26

Wikinaut opened this issue Feb 4, 2021 · 9 comments · May be fixed by #29

Comments

@Wikinaut
Copy link

Wikinaut commented Feb 4, 2021

No description provided.

@arkonbob
Copy link

arkonbob commented Feb 22, 2021

The attached addon.xml and main.py make the addon compatible with 19 (filename extension changed to .txt for upload here). Simply change the filename extension back to the original and copy them to ~/.kodi/addons/plugin.audio.radiobrowser to install.

I've checked out the code and branched, happy to push and create a pull request if granted permission.

addon.txt
main.txt

@Wikinaut
Copy link
Author

@arkonbob I am just asking: is there a specific reason why you haven't submitted your changes as a formal pull request?

@arkonbob
Copy link

Tried to push my branch to origin, I don't have permission. I assume I need to be granted permission to contribute. In the meantime I thought others might want to get the update while I wait.

@Wikinaut
Copy link
Author

Wikinaut commented Feb 22, 2021

@arkonbob you misunderstood me. I meant a pull request. You make your changes in fix-issue-26 branch in a personal fork (yes, you have to fork it) of this repository. Then - in your fork - you click to start a so-called pull-request to the parent repository (this here). Then the owner can accept your pull-request, then it becomes merged.

@gazer22
Copy link

gazer22 commented Feb 23, 2021

@arkonbob - I just put your changes into a pull request. Thanks - works on my system!

@arkonbob
Copy link

arkonbob commented Feb 25, 2021

@Wikinaut Not a misunderstanding, just my inexperience with Github. At work I would just create a branch, push it and create a PR from that. I just assumed the process was similar here.

@gazer22 thanks for sorting it out, I'll know for next time.

@Wikinaut
Copy link
Author

@arkonbob Pull-requests are the only correct way to do it here on github when you are not owner (or group member or organisation member - I am not, too) of a github repository, I think, everyone of us here had to learn that once. Well done, and thanks.

@narcisgarcia
Copy link

Current link to kody repository is broken. At Kodi project they've splitted plugins catalog by Kodi versions:
https://kodi.tv/addons/leia/plugin.audio.radiobrowser
https://kodi.tv/addons/matrix/plugin.audio.radiobrowser

Second one will be available when fixed plugin is pushed there.

@pvagner pvagner linked a pull request Sep 5, 2021 that will close this issue
@narcisgarcia
Copy link

This project seems not maintained.
Is there some way to anybody installs this plugin to Kodi 19?
Could this project or a fork be supported by Github virtual repository?
https://github.com/i96751414/repository.github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants