-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the app is not compatible with Kodi 19 #26
Comments
The attached addon.xml and main.py make the addon compatible with 19 (filename extension changed to .txt for upload here). Simply change the filename extension back to the original and copy them to ~/.kodi/addons/plugin.audio.radiobrowser to install. I've checked out the code and branched, happy to push and create a pull request if granted permission. |
@arkonbob I am just asking: is there a specific reason why you haven't submitted your changes as a formal pull request? |
Tried to push my branch to origin, I don't have permission. I assume I need to be granted permission to contribute. In the meantime I thought others might want to get the update while I wait. |
@arkonbob you misunderstood me. I meant a pull request. You make your changes in fix-issue-26 branch in a personal fork (yes, you have to fork it) of this repository. Then - in your fork - you click to start a so-called pull-request to the parent repository (this here). Then the owner can accept your pull-request, then it becomes merged. |
@arkonbob - I just put your changes into a pull request. Thanks - works on my system! |
@arkonbob Pull-requests are the only correct way to do it here on github when you are not owner (or group member or organisation member - I am not, too) of a github repository, I think, everyone of us here had to learn that once. Well done, and thanks. |
Current link to kody repository is broken. At Kodi project they've splitted plugins catalog by Kodi versions: Second one will be available when fixed plugin is pushed there. |
This project seems not maintained. |
No description provided.
The text was updated successfully, but these errors were encountered: