Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave regression: No iiif manifest detection for some sites #3

Open
mprove opened this issue Jul 6, 2024 · 3 comments
Open

Brave regression: No iiif manifest detection for some sites #3

mprove opened this issue Jul 6, 2024 · 3 comments

Comments

@mprove
Copy link

mprove commented Jul 6, 2024

[1] https://goobi-viewer.univie.ac.at/viewer/image/AC12002996/
[2] https://portal.daten.zkm.de/archive/herbert_w_franke/manuskripte?hideNav=true&hideAdv=true&details=1547

It would be cool to detect button elements such as

<button id="iiifManifest" class="badge badge-dark widget-usage__work-download-iiif" data-copy-value="https://goobi-viewer.univie.ac.at/viewer/api/v1/records/AC12002996/manifest/" data-copy-done-msg="Copied to clipboard" title="" aria-label="Map Volume: IIIF manifest" tabindex="0" data-original-title="Copy URL"> IIIF manifest </button>

[UPDATE] Brave bug; Chrome ok; [1] and [2] used to work with Brave and detektiiif2

@leanderseige
Copy link
Member

Hm, for me this works:
image

@mprove
Copy link
Author

mprove commented Jul 6, 2024

Environment: macos, Brave Version 1.66.118 Chromium: 125.0.6422.147 (Official Build) (arm64)
Confusing version info for the plugin: detektIIIF3 0.3.3 OR from the about box: detektIIIF2 Version 0.1.0 / Theme Version 0.3.3

Good news update: It works fine under macos Chrome Version 126.0.6478.127. Hence it is a Brave vs. detektiiiff issue.

Screenshot 2024-07-06 at 11 06 50

@mprove mprove changed the title RFE: No iiif manifest detection for U Vienna Brave bug: No iiif manifest detection for U Vienna Jul 6, 2024
@mprove mprove changed the title Brave bug: No iiif manifest detection for U Vienna Brave regression: No iiif manifest detection for U Vienna Jul 7, 2024
@mprove mprove changed the title Brave regression: No iiif manifest detection for U Vienna Brave regression: No iiif manifest detection for some sites Jul 7, 2024
@mprove
Copy link
Author

mprove commented Jul 9, 2024

This regression bug is getting bigger. French Library BnF is detected under macos Chrome, but not with Brave anymore.
Example: https://gallica.bnf.fr/view3if/ga/ark:/12148/btv1b8458483k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants