-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve admin tools #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things I've noticed:
- I'm not sure if it's only happening with me, but after editing a user's picture, it no longer appears when I'm in the edit page for that user.
- Creating a new Company causes the following error:
- Updating social media currently has no effect. More on it in the comments
isset()
returnstrue
when evaluating an array of keys with null values, which in this case means it will always return true, regardless of whether I type anything in the social media inputs or not (for example), and it will also create those types of arrays in the database. Not sure if this was intended or not, my idea was that an entry in the SocialMedia table would only be created/updated if anything was typed in the social media inputs. However, if this behavior is fixed, maybe we would need to remove that check when updating, as I might want to delete all of my social media from the website (and that will be impossible if arrays of keys with null values are properly filtered).
This is caused by two things, firstly, you have to run the This works for me. You probably need to migrate the db.
|
Related to #58.