Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated default timeout in rule-file-perf-principles #1928

Closed
jkylekelly opened this issue Jan 25, 2025 · 1 comment · Fixed by #1940
Closed

Outdated default timeout in rule-file-perf-principles #1928

jkylekelly opened this issue Jan 25, 2025 · 1 comment · Fixed by #1940
Assignees

Comments

@jkylekelly
Copy link

Currently, https://semgrep.dev/docs/kb/rules/rule-file-perf-principles states:

The time for matching is number of files * time to match each file. The time to check each file can also grow, in the worst case, exponentially, especially when a rule has a lot of matches in subpatterns. However, the default settings of --timeout 30 --timeout-threshold 3 means that a file times out if:
30 seconds elapse without the match process completing
3 rules time out

However, the default --timeout assignment is 5s and not 30s.

@s-santillan
Copy link
Collaborator

@khorne3 this is your bebe!
Thanks @jkylekelly for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants