Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction to build semgrep-core from source refers to missing Makefile target #976

Open
amfarrell opened this issue Apr 27, 2023 · 0 comments

Comments

@amfarrell
Copy link

amfarrell commented Apr 27, 2023

I got an error when I ran make build-core as I was following the instructions to build semgrep-core from source.

make: *** No rule to make target `build-core'.  Stop.

This prevented me from following the recommended way to get a semgrep-core binary as I was setting up a development environment to contribute to semgrep-cli. I saw this slack thread, which showed that another person had encountered the same problem with that instruction. I ran git log -S'build-core' -- Makefile on the develop branch of semgrep and I found that the instruction fell out of date as a result of this code change which removed the Makefile target build-core.

I would like help to update the docs with the correct instruction for new contributors to build semgrep-core from source.

@amfarrell amfarrell changed the title Update command to build semgrep-core from source Instruction to build semgrep-core from source refers to missing Makefile target May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@amfarrell and others