Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement Hebrew translation #426

Merged
merged 6 commits into from
Dec 14, 2023
Merged

improvement Hebrew translation #426

merged 6 commits into from
Dec 14, 2023

Conversation

ShlomoCode
Copy link
Contributor

@ShlomoCode ShlomoCode commented Jul 24, 2023

this pr corrects the masculine/feminine language in Hebrew according to the guidelines of the official Hebrew language academy, and many other translation fixes.

https://hebrew-academy.org.il/2010/10/04/%D7%90%D7%99%D7%9A-%D7%A4%D7%95%D7%A0%D7%99%D7%9D-%D7%9C%D7%A7%D7%91%D7%95%D7%A6%D7%94-%D7%A9%D7%A8%D7%95%D7%91%D7%94-%D7%A0%D7%A9%D7%99%D7%9D/#:~:text=%D7%A6%D7%95%D7%A8%D7%AA%20%D7%94%D7%96%D7%9B%D7%A8%20%D7%91%D7%A2%D7%91%D7%A8%D7%99%D7%AA%20%D7%9E%D7%A9%D7%9E%D7%A9%D7%AA%20%D7%9C%D7%90%20%D7%A8%D7%A7%20%D7%9C%D7%96%D7%9B%D7%A8.%20%D7%94%D7%99%D7%90%20%D7%92%D7%9D%20%D7%94%D7%A6%D7%95%D7%A8%D7%94%20%D7%A9%D7%90%D7%A0%D7%97%D7%A0%D7%95%20%D7%A0%D7%95%D7%A7%D7%98%D7%99%D7%9D%20%D7%9B%D7%A9%D7%90%D7%99%D7%9F%20%D7%9C%D7%A0%D7%95%20%D7%A6%D7%95%D7%A8%D7%9A%20%D7%9C%D7%94%D7%91%D7%97%D7%99%D7%9F%20%D7%91%D7%9E%D7%99%D7%9F%20%E2%80%93%20%D7%9B%D7%9C%D7%95%D7%9E%D7%A8%20%D7%94%D7%99%D7%90%20%D7%92%D7%9D%20%D7%94%D7%A6%D7%95%D7%A8%D7%94%20%D7%94%D7%A1%D7%AA%D7%9E%D7%99%D7%AA%2C%20%D7%94%D7%9C%D7%90%20%D7%9E%D7%A1%D7%95%D7%9E%D7%A0%D7%AA

CleanShot 2023-07-24 at 20 32 26@2x

https://hebrew-academy.org.il/2021/03/15/%D7%A2%D7%9C-%D7%9B%D7%AA%D7%99%D7%91%D7%94-%D7%A9%D7%95%D7%95%D7%99%D7%95%D7%A0%D7%99%D7%AA/#:~:text=%D7%94%D7%9B%D7%A0%D7%A1%D7%AA%20%D7%A0%D7%A7%D7%95%D7%93%D7%95%D7%AA%20%D7%90%D7%95%20%D7%9C%D7%95%D7%9B%D7%A1%D7%A0%D7%99%D7%9D%20%D7%91%D7%AA%D7%95%D7%9A%20%D7%94%D7%9E%D7%99%D7%9C%D7%94%20%D7%90%D7%99%D7%A0%D7%94%20%D7%9C%D7%A4%D7%99%20%D7%9B%D7%9C%D7%9C%D7%99%20%D7%94%D7%9B%D7%AA%D7%99%D7%91%D7%94%20%D7%A9%D7%9C%20%D7%94%D7%A2%D7%91%D7%A8%D7%99%D7%AA
CleanShot 2023-07-24 at 20 34 04@2x

PR Checklist

  • This PR doesn't modify the files in the spec dir.
  • This PR passes npm run lint.
  • (Optional) If you're willing to help reviews about your language's translations, add your name to the TRANSLATORS.md.

@ShlomoCode
Copy link
Contributor Author

@JohnTitor Could you maybe check this?
Thanks

@JohnTitor
Copy link
Member

I'd like to get a review from native speakers, @YanivD @nirsky @blumamir could you review this if you have time?

@JohnTitor

This comment was marked as outdated.

Copy link
Contributor

@YanivD YanivD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a native Hebrew speaker - LGTM

@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented Nov 23, 2023

@JohnTitor it's Ready to merge

@ShlomoCode
Copy link
Contributor Author

🤔

@JohnTitor JohnTitor merged commit db267da into semver:gh-pages Dec 14, 2023
1 check passed
@JohnTitor
Copy link
Member

Sorry for the delay and thank you all for contributing and reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants