Indicated as late when Turnaround Time is zero

[DanE417]

Description

When Turnaround time has a value of zero (0 days, 0 hours, 0 minutes), the analysis is still marked as late. This is because in src/bika/lims/content/abstractroutineanalysis.py, line 209, "if not tat:” does not meet the condition to be accessed because variable "tat" is not None but of zero value. This will then not return the correct value. This is also true for src/bika/lims/content/abstractanalysis.py, line 688, "if not maxtime:".

Reproduction guide

Create an Analysis service and set the "Maximum turn-around time" to Days 0, Hours 0, Minutes 0.
Create a sample with the newly created analysis service.
Receive the sample.
It should now show as late.

Observed behaviour

When the Sample is received and it has a maximum turn-around time of zero (0) it shows as late.

Expected behaviour

When the Sample is received and it has a maximum turn-around time of zero (0) it shows as not late.

Versions

• OS: Linux

• senaite.core: master

• senaite.impress: master

• senaite.core.listing: master

• senaite.core.supermodel: master

Traceback

<<BACKTRACE IF RELEVANT>>

Screenshot