Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Activity properties in schema_manager #616

Open
maxsibilla opened this issue Feb 7, 2025 · 1 comment · May be fixed by #657
Open

Address Activity properties in schema_manager #616

maxsibilla opened this issue Feb 7, 2025 · 1 comment · May be fixed by #657
Assignees

Comments

@maxsibilla
Copy link
Contributor

maxsibilla commented Feb 7, 2025

Related to #606

  • schema_manager specifically in any of the normalize functions
    • We have to add protocol_url to properties_to_include since these functions work strictly off of the provenance schema
@maxsibilla maxsibilla added this to CODCC Feb 7, 2025
@maxsibilla maxsibilla converted this from a draft issue Feb 7, 2025
@libpitt
Copy link
Contributor

libpitt commented Feb 21, 2025

Currently the filter_properties feature query returns any requested property name clashes between Entity and Activity with an appended prefix activity_.

To this date's implementation, any clashed requested properties will only return the ones for Entity in the response.

When reworking the method normalize_entities_list_for_response, if needed to include both of such clashed fields, would need to consider this scenario in order to return the clashed fields for both Activity and Entity in the response.

Image

@libpitt libpitt self-assigned this Feb 26, 2025
libpitt added a commit that referenced this issue Mar 3, 2025
Remove excessive calls to get_entity_creation_action_activity #616 #650
libpitt added a commit that referenced this issue Mar 5, 2025
@libpitt libpitt linked a pull request Mar 6, 2025 that will close this issue
@libpitt libpitt moved this from Ready to Review/QA in CODCC Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging a pull request may close this issue.

2 participants