Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get/setIndent() does not exists on PHP 8.x #42

Open
Sweetchuck opened this issue Sep 1, 2021 · 0 comments
Open

get/setIndent() does not exists on PHP 8.x #42

Sweetchuck opened this issue Sep 1, 2021 · 0 comments

Comments

@Sweetchuck
Copy link

The sass PHP extension can be compiled from source with PHP 8.x (8.0.10), but the \Sass::getIndent() and \Sass::setIndent() methods aren't exist.

Maybe this one is the relevant output:

src/ast_values.cpp: In member function ‘virtual size_t Sass::Number::hash() const’:
src/ast_values.cpp:431:23: warning: loop variable ‘numerator’ creates a copy from type ‘const std::__cxx11::basic_string<char>’ [-Wrange-loop-construct]
  431 |       for (const auto numerator : numerators)
      |                       ^~~~~~~~~
src/ast_values.cpp:431:23: note: use reference type to prevent copying
  431 |       for (const auto numerator : numerators)
      |                       ^~~~~~~~~
      |                       &
src/ast_values.cpp:433:23: warning: loop variable ‘denominator’ creates a copy from type ‘const std::__cxx11::basic_string<char>’ [-Wrange-loop-construct]
  433 |       for (const auto denominator : denominators)
      |                       ^~~~~~~~~~~
src/ast_values.cpp:433:23: note: use reference type to prevent copying
  433 |       for (const auto denominator : denominators)

PHP 7.x (7.4 and 7.3) works fine.
LIBSASS_VERSION="3.6.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant