Don't include domain name for MSCHAPv2 challenge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect patch in a54258a.
Rogdham
force-pushed
the
fix-mschapv2-dont-include-domain-name
branch
from
4fce04d to
da0f37e
Compare
|
Aah perfect. I've been trying to track this down. hostapd already had code to do this but I didn't modify our logging code. Thanks very much. |
singe
added a commit
that referenced
this pull request
Jan 15, 2016
Don't include domain name for MSCHAPv2 challenge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wrote the initial patch for hostapd-wpe that seems to have been ported to hostapd-mana in a54258a.
As a reminder, the problem is that
domain\usernamecan be sent as the user, but onlyusernameshould be considered to compute the challenge/response.However, there was a small bug in porting the patch, and the issue is still present with the current version of hostapd-mana. This PR aims to fix it.
Feel free to come back to me if anything is unclear.
Related bug on the mana repository.