Handle assets from the Symfony component #125
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Dec 12, 2024
|
|
||
| foreach ($this->inner->getFunctions() as $function) { | ||
| if ('asset' === $function->getName()) { | ||
| $function = new TwigFunction('asset', $this->getAsset(...), ['needs_context' => true]); |
There was a problem hiding this comment.
So this extension will decorate my entire app usage of "asset" ? ... well...
There was a problem hiding this comment.
Since the PathPackage does not include the host, asset cannot work in a Gotenberg context.
How can we make it working without decorating it ? I was also thinking about the <base> tag to solve this problem but it's not recommended.
|
A custom asset package would not work here ? |
If this package uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121
Allow using the
assettwig function from the TwigBridge for public assets.