Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonsai fix #386

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Bonsai fix #386

merged 2 commits into from
Jan 8, 2021

Conversation

nixwiz
Copy link
Contributor

@nixwiz nixwiz commented Dec 29, 2020

Signed-off-by: Todd Campbell [email protected]

Pull Request Checklist

Closes #385

Cutting a release with this .bonsai.yml will allow the asset to work with Bonsai.

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • [X Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

Todd Campbell added 2 commits December 29, 2020 09:43
Signed-off-by: Todd Campbell <[email protected]>
Signed-off-by: Todd Campbell <[email protected]>
Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majormoses majormoses merged commit 71ef7b7 into master Jan 8, 2021
@majormoses
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonsai asset deployment failing
2 participants