Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate interrupts stat #19

Open
eberkut opened this issue Jan 30, 2017 · 1 comment
Open

Inaccurate interrupts stat #19

eberkut opened this issue Jan 30, 2017 · 1 comment

Comments

@eberkut
Copy link

eberkut commented Jan 30, 2017

I think there's an issue with the reporting of interrupts from metrics-cpu.rb.

As per https://www.kernel.org/doc/Documentation/filesystems/proc.txt (section 1.8):

The "intr" line gives counts of interrupts serviced since boot time, for each
of the possible system interrupts. The first column is the total of all
interrupts serviced including unnumbered architecture specific interrupts;
each subsequent column is the total for that particular numbered interrupt.

However, in the metrics check

output "#{config[:scheme]}.#{name}", info.last if other_metrics.include? name

This will return the last element of the array for each stat including intr. However, for intr the total is actually the first element. The last column is just the total for a given interrupt (which can actually vary between platform).

Using sensu-plugins-cpu-checks 1.0.0.

@majormoses majormoses added the Bug label May 2, 2017
@majormoses
Copy link
Member

@eberkut would you be willing to put togethor a pr for a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants