5002-manual check execution bugfix #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManishaKumari295
force-pushed
the
bugfix/manualCheckExe_5002
branch
from
2f17c12 to
fd92f77
Compare
|
Test case- TestProcessCheck() ,test result attach |
fguimond
reviewed
Feb 13, 2024
backend/schedulerd/executor.go
Outdated
| //display matched entities | ||
| matchedEntityJson, _ := json.Marshal(matchedEntities) | ||
| matchedEntityJsonData := string(matchedEntityJson) | ||
| logger.WithFields(fields).Infof("matched entities: %s", matchedEntityJsonData) |
There was a problem hiding this comment.
I like the idea of a log here but it should probably be at the Debug level, as we might not want to view this under normal operations.
There was a problem hiding this comment.
I like the idea of a log here but it should probably be at the Debug level, as we might not want to view this under normal operations.
Removed the logs from code
|
Nice clean fix, the draft status can be removed. Well done! |
|
LGTM. Just make sure you sign-off your commits ( |
|
Don't forget to add a changelog entry. |
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
ManishaKumari295
force-pushed
the
bugfix/manualCheckExe_5002
branch
from
9cb2b06 to
1b44a38
Compare
Added the changelog.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #5002
Description
Each manual execution of a check via the web UI or sensuctl, must execute normally as it runs when scheduled.
Change in behavior
Manual execution of check used to throw an error of -'no matching entity found". With the changes made in context pass, the behaviour and fixed and matching entities are found.
Added
Nothing added ,only modification in existing function
Changed
The adhoc request of check execution is now processsed with the Context from resource that that an added namespace key in it.
changes are made listenQueue() and ProcessCheck() in executor.go in schedulered directory.
Fixed
This fixes the entity fetch for the manual executed check and is shown in logs after execution.
Change verification
Added log snippet of scheduler , which comes on manual check execution .
Snippet of testcase execution is also attached.