Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on redis 6.2.7 and redis 7.0 due to globally reachable lua tables becoming read only #89

Open
bak1an opened this issue May 3, 2022 · 0 comments · May be fixed by #90
Open

Fails on redis 6.2.7 and redis 7.0 due to globally reachable lua tables becoming read only #89

bak1an opened this issue May 3, 2022 · 0 comments · May be fixed by #90

Comments

@bak1an
Copy link

bak1an commented May 3, 2022

docker run -it --rm -p 127.0.0.1:6379:6379 redis:6.2.7 and make test fails all tests due to tables becoming read only:

...
======================================================================
FAIL: Cannot fail a job that doesn't exist
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/test/qless-core/test/test_fail.py", line 84, in test_fail_nonexistent
    self.lua, 'fail', 1, 'jid', 'worker', 'group', 'message', {})
  File "/home/test/qless-core/test/common.py", line 41, in assertRaisesRegexp
    '%s does not match %s' % (str(exc), regex))
AssertionError: Error running script (call to f_1c4a4e283c4a97440f92a680b4aa0c4c070ee1e9): @user_script:27: user_script:27: Attempt to modify a readonly table does not match does not exist

======================================================================
FAIL: Cannot complete a job that doesn't exist
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/test/qless-core/test/test_job.py", line 99, in test_complete_nonexistent
    self.lua, 'complete', 1, 'jid', 'worker', 'queue', {})
  File "/home/test/qless-core/test/common.py", line 41, in assertRaisesRegexp
    '%s does not match %s' % (str(exc), regex))
AssertionError: Error running script (call to f_1c4a4e283c4a97440f92a680b4aa0c4c070ee1e9): @user_script:27: user_script:27: Attempt to modify a readonly table does not match does not exist
...
Ran 243 tests in 0.368s

FAILED (errors=220, failures=6)

Same with redis 7.

With 6.2.6 and prior releases it still works.

Related redis PR: redis/redis#10651

Have not used lua before, not sure what would be the proper way to workaround that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert method table.extend() to a local function because 'table' is … tom93/qless-core
1 participant
@bak1an