Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxi start starts at the last entry's end, not at "now" #130

Open
gnutix opened this issue May 19, 2020 · 2 comments
Open

taxi start starts at the last entry's end, not at "now" #130

gnutix opened this issue May 19, 2020 · 2 comments

Comments

@gnutix
Copy link
Contributor

gnutix commented May 19, 2020

Given :

# 05.tks
19/05/2020 # Tuesday
TT-1    09:00-10:00    TT-1 entry

If I type taxi start TT-1 at noon (12:00), it will add a new entry :

# 05.tks
19/05/2020 # Tuesday
TT-1    09:00-10:00    TT-1 entry
+TT-1 10:00-? ?

I would have expected it to be :

# 05.tks
19/05/2020 # Tuesday
TT-1    09:00-10:00    TT-1 entry
+TT-1 12:00-? ?
@gnutix
Copy link
Contributor Author

gnutix commented May 19, 2020

Related : #131 (so if I run taxi start at 13:54, it would write TT-1 13:54-? ?

@sephii
Copy link
Owner

sephii commented Jun 17, 2020

It's a feature to prevent having small gaps when timesheeting, eg. if you run taxi stop, then take a small break, or take some time figuring out what you'll work on next, running taxi start should continue the previous entry. I agree it can be confusing and error prone though.

I can think of several ways of fixing this. First one would be to set a threshold above which the new entry uses the current time instead of the activity end time. Second one would be to introduce a --continue flag to the start entry (or a continue command), to keep the current behaviour of continuing the previous entry. I think #2 is better, but it's not easy to do, because it would require careful consideration of the duration rounding, to make sure the new entry doesn't start before the last one (and it might also create surprises where taxi start doesn't actually use the current time if the previous entry end time is in the future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants