Skip to content

serde_derive compilation fails on windows gnu with rust nightly #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sagiegurari opened this issue Mar 16, 2018 · 2 comments
Closed

serde_derive compilation fails on windows gnu with rust nightly #1180

sagiegurari opened this issue Mar 16, 2018 · 2 comments
Labels
build

Comments

@sagiegurari
Copy link

See example build at:

https://ci.appveyor.com/project/sagiegurari/cargo-make/build/1.0.600/job/tt03ws1pdppwq6u2#L176

I see that you do not run builds on gnu in appveyor so you will not see it.
So I suggest apart of a fix to also add it to the appveyor matrix.
@dtolnay
Copy link
Member

dtolnay commented Mar 16, 2018

Thanks, this is being tracked in rust-lang/rust#49044.

@dtolnay
Copy link
Member

dtolnay commented Mar 18, 2018

Upstream indicates that this has been fixed. Please leave a comment in rust-lang/rust#49044 if you find it has not been fixed for you as of the most recent nightly.

I filed #1182 to track adding an x86_64-pc-windows-gnu build in AppVeyor.

@dtolnay dtolnay closed this as completed Mar 18, 2018
@dtolnay dtolnay added the build label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtolnay @sagiegurari