-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nanpercentile #2187
Comments
Hey @ashwinvis : I'd go with implementatin For the details, numpy algorithms seems to be based on https://github.com/numpy/numpy/blob/3b246c6488cf246d488bbe5726ca58dc26b6ea74/numpy/lib/_function_base_impl.py#L4830 |
I agree, all functions seem to be based on |
@serge-sans-paille I saw that xtensor made a C++ port of quantile and its many variants. Do you think it can be ported using Pythran's pythonic? I know that you have commented in the past (#1476) that xtensor's approach is incompatible. I wonder if it is true for this function. |
Function
nanpercentile
in numpy can be awfully slow if we useaxis=0
when the number of columns are a huge, or vice-versa. This is noted here:And I have a use-case for this from work.
There are faster JIT-versions of this now in numbaagg, jax etc, but it will be easier to ship something statically compiled á la Pythran. Any pointers to get started?
Possible follow-up easy quick-wins
nanquantile(a, q, ...)
=nanpercentile(a, q*100, ...)
nanmedian(a, ...)
=nanpercentile(a, 50, ...)
The text was updated successfully, but these errors were encountered: