Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log blocks application with some timeout when Sentry dns is not available. #9

Open
chromigo opened this issue Jul 20, 2018 · 5 comments
Labels

Comments

@chromigo
Copy link

chromigo commented Jul 20, 2018

Log blocks application with some timeout when Sentry dns is not available.
I see 2 solutions of problem:

  • The easiest - to install package https://github.com/serilog/serilog-sinks-async and use .WriteTo.Async(a => a.Sentry(sinkOptions.Dns)); syntax + do not forget to call Log.CloseAndFlush(); or .Dispose()
  • Change Sink implementation, for example something like PeriodicBatchingSink

to simulate timeout you can add some invalid port to dns string, like [email protected]:81/id

@olsh olsh self-assigned this Jul 23, 2018
@olsh olsh removed their assignment Jul 31, 2018
@PureKrome
Copy link

So is the current suggestion for people is use the serilog-sinks-async with this Sentry sink?

@olsh
Copy link
Member

olsh commented May 22, 2019

Yes, I personally use the approach with serilog-sinks-async.
I don't think this feature will be implemented since there is an official library now, this repository will be eventually archived when they release stable support for MVC5.
getsentry/sentry-dotnet#168

@PureKrome
Copy link

Ah - so this repo is not the official one?

@olsh
Copy link
Member

olsh commented May 22, 2019

Yes, this is a non-official library, here is the official one.
https://github.com/getsentry/sentry-dotnet

@PureKrome
Copy link

ta

@olsh olsh added the wontfix label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants