Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is axios required? #12

Closed
seriouslag opened this issue Jan 19, 2022 · 1 comment
Closed

Is axios required? #12

seriouslag opened this issue Jan 19, 2022 · 1 comment
Labels
question Further information is requested

Comments

@seriouslag
Copy link
Owner

Instead of requiring axios we could pass in a HttpClientAdaptor interface that would abstract the calls to the underlying software. Could use axios, fetch, node-fetch.

My only issue with this starting out is that it clouds the usability of the package since this package would ALWAYS be relying on another package to use.
@seriouslag seriouslag added the question Further information is requested label Jan 19, 2022
@seriouslag
Copy link
Owner Author

Split axios into a separate package in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seriouslag